Skip to content

On Linux/MacOS, command passed to subprocess.check_output should be a string rather than a list #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2015
Merged

On Linux/MacOS, command passed to subprocess.check_output should be a string rather than a list #330

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b42e755
In Linux/Mac, subprocess.check_output requires a string as first argu…
Aug 25, 2015
91ac82d
Modify subprocess command for MacOS.
Aug 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,19 @@ def _get_plugin_tsc_version():
cmd = [get_node_path(), TSC_PATH, "-v"]
return _execute_cmd_and_parse_version_from_output(cmd)

def _is_executable(path):
return os.path.isfile(path) and os.access(path, os.X_OK)

def _get_npm_tsc_version():
cmd = ["tsc", "-v"]
if os.name != 'nt' and _is_executable("/usr/local/bin/tsc"): # Default location on MacOS
cmd = [get_node_path(), "/usr/local/bin/tsc", "-v"]
else:
cmd = ["tsc", "-v"]
return _execute_cmd_and_parse_version_from_output(cmd)

def _execute_cmd_and_parse_version_from_output(cmd):
if os.name != 'nt': # Linux/MacOS
cmd = "'" + "' '".join(cmd) + "'"
output = subprocess.check_output(cmd, shell=True).decode('UTF-8')

# Use regex to parse the verion number from <output> e.g. parse
Expand Down