Skip to content

Update core dependencies #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

typescript-bot
Copy link
Contributor

Automated changes by create-pull-request GitHub action

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/ImageDecoder)
*/
interface ImageDecoder {
Copy link
Contributor

@HolgerJeromin HolgerJeromin Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MDN takes a few days after BCD release happens. Best to check BCD directly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same in the data.
133 will be released 2024-11-26 as shown nicely in mdn :)

https://github.com/mdn/browser-compat-data/blob/main/api/ImageDecoder.json

Copy link
Contributor

@saschanaz saschanaz Nov 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, any features riding release train as enabled-by-default are treated as a support. Because:

  1. Being enabled by default usually means it won't go away, meaning no back and forth in the lib.
  2. It takes some times until it reaches to a new TS release, and by that time the browsers release will happen already.

@saschanaz
Copy link
Contributor

LGTM

@github-actions github-actions bot merged commit 3c1050f into microsoft:main Nov 2, 2024
5 checks passed
Copy link
Contributor

github-actions bot commented Nov 2, 2024

Merging because @saschanaz is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants