Skip to content

Conversation

@mrienstra
Copy link
Contributor

@mrienstra mrienstra commented Oct 22, 2022

See #1383 (comment).

Reasonably confident, but also wondering if there is a tight correspondence between these versions, it's possible there were changes made in third-party sources during this 18-day gap:
Jul 02, 2022: @types/web@0.0.69
July 20, 2022: v4.8-rc microsoft/TypeScript#49976

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@orta
Copy link
Contributor

orta commented Oct 22, 2022

There were no commits to the generated dom file in the typescript repo till September, so I'd say this is very likely accurate 👍🏻

@saschanaz
Copy link
Contributor

I also believe this is accurate, since https://github.com/microsoft/TypeScript/pull/49976/files shows @types/web@0.0.68...@types/web@0.0.69.

LGTM thus.

@github-actions github-actions bot merged commit 4d90e54 into microsoft:main Oct 23, 2022
@github-actions
Copy link
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

@mrienstra mrienstra deleted the patch-1 branch October 23, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants