Skip to content

Add integrity to script and link #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add integrity to script and link #113

wants to merge 1 commit into from

Conversation

haskellcamargo
Copy link

Reference: microsoft/TypeScript#8955

This pull-request adds the property integrity for the interfaces HTMLScriptElement and HTMLLinkElement according to W3 recommendation.

let script = document.createElement('script');
script.integrity = "sha-256-some-hash"

@msftclas
Copy link

msftclas commented Jun 4, 2016

Hi @haskellcamargo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@mhegazy
Copy link
Contributor

mhegazy commented Jun 4, 2016

@haskellcamargo can you fix the failing tests please.

@mhegazy
Copy link
Contributor

mhegazy commented Jun 4, 2016

This file is not edited. this file is auto-generated, hence the ".generated" suffix in the file name.

The file you need to edit is https://github.com/Microsoft/TSJS-lib-generator/blob/master/inputfiles/addedTypes.json

Please see https://github.com/Microsoft/TSJS-lib-generator#contribution-guidelines

@haskellcamargo
Copy link
Author

Ah, sorry! I'll check it and fix it.

@mhegazy
Copy link
Contributor

mhegazy commented Oct 14, 2016

Original issue has been fixed by #134. closing.

@mhegazy mhegazy closed this Oct 14, 2016
orta added a commit to orta/TSJS-lib-generator that referenced this pull request Jul 1, 2021
* Add stylemedia

* Update inputfiles/addedTypes.json

Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants