Repository navigation
HTMLElement onchange should use this: this #195
Description
This example worked in 2.0, but not in 2.1:
const input = document.createElement('input');
input.value; // OK
input.onchange = function() {
this.value; // Error
}The current definition for onchange in HTMLElement is: onchange: (this: HTMLElement, ev: Event) => any;. Maybe it should use this: this?
Activity
mhegazy commentedon Feb 17, 2017
Duplicate of microsoft/TypeScript#12490
I broke this with my change #166 to reduce instantiations in the library, by making less types generic (types using
thisare implicitly generic with respect tothis).The fix here is to generate
onChangeevents for the type hierarchy with the correct type, instead of putting in the parent with typethis.mhegazy commentedon Feb 18, 2017
correct.
myitcv commentedon Mar 15, 2017
Given that microsoft/TypeScript#14141 has now been merged, what is left to do to fix this issue and microsoft/TypeScript#12490?
I note that with with
2.3.0-dev.20170315andnoImplicitThisthe following still types incorrectly (per microsoft/TypeScript#12490):saschanaz commentedon May 4, 2017
This won't help custom elements, and probably will generate much longer library file. (60+ lines per one HTMLElement interface, 80+ HTMLElements = 4800+ more lines)
The PR explicitly says that it works only on --noImplicitAny so I think it's not applicable to this issue.
Bashamega commentedon Jun 28, 2025
Hello Kagami Sascha Rosylight (@saschanaz)
I have created a solution for this.
The solution is to specifically update in the emitter to replace
GlobalEventHandlerstothis. I have already tested my solution, and it worked.I can open a pr for it
saschanaz commentedon Jun 28, 2025
Please take a look of #195 (comment) and microsoft/TypeScript#12490, it was done and reverted because of performance regression.
Bashamega commentedon Jun 29, 2025
Do you have another solution to propose?