Skip to content

Comments

perf: reduce lightgbm prediction time by 20%#872

Open
imatiach-msft wants to merge 1 commit intomicrosoft:masterfrom
imatiach-msft:ilmat/reduce-pred-mem-churn
Open

perf: reduce lightgbm prediction time by 20%#872
imatiach-msft wants to merge 1 commit intomicrosoft:masterfrom
imatiach-msft:ilmat/reduce-pred-mem-churn

Conversation

@imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Jun 3, 2020

perf: reduce lightgbm prediction time by 20%
depends on native changes:
microsoft/LightGBM#3159
In testing, time went from 82159416923ns to 65852779813ns on the pima dataset (test added in PR but num iterations was 10000, not 100 as in PR for performance testing).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft imatiach-msft changed the title perf: reduce memory churn on predict [WIP] perf: reduce memory churn on predict Jun 3, 2020
@imatiach-msft imatiach-msft force-pushed the ilmat/reduce-pred-mem-churn branch from 48ef541 to 814132a Compare June 3, 2020 05:37
@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #872 into master will decrease coverage by 1.09%.
The diff coverage is 58.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #872      +/-   ##
==========================================
- Coverage   85.22%   84.13%   -1.10%     
==========================================
  Files         189      189              
  Lines        8733     8722      -11     
  Branches      543      523      -20     
==========================================
- Hits         7443     7338     -105     
- Misses       1290     1384      +94     
Impacted Files Coverage Δ
...m/microsoft/ml/spark/lightgbm/LightGBMRanker.scala 13.79% <0.00%> (-44.83%) ⬇️
...icrosoft/ml/spark/lightgbm/LightGBMRegressor.scala 14.89% <0.00%> (-53.20%) ⬇️
...osoft/ml/spark/lightgbm/LightGBMModelMethods.scala 50.00% <40.00%> (-16.67%) ⬇️
.../microsoft/ml/spark/lightgbm/LightGBMBooster.scala 83.56% <63.63%> (-4.41%) ⬇️
...crosoft/ml/spark/lightgbm/LightGBMClassifier.scala 87.80% <100.00%> (ø)
.../com/microsoft/ml/spark/lightgbm/TrainParams.scala 73.68% <0.00%> (-26.32%) ⬇️
.../microsoft/ml/spark/lightgbm/LightGBMDataset.scala 74.00% <0.00%> (-22.00%) ⬇️
...a/com/microsoft/ml/spark/lightgbm/TrainUtils.scala 80.86% <0.00%> (-6.50%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64481e9...37f9751. Read the comment docs.

@imatiach-msft imatiach-msft force-pushed the ilmat/reduce-pred-mem-churn branch from 814132a to 81fa621 Compare June 11, 2020 04:18
@imatiach-msft imatiach-msft force-pushed the ilmat/reduce-pred-mem-churn branch from 81fa621 to 37f9751 Compare June 11, 2020 06:20
@imatiach-msft imatiach-msft changed the title [WIP] perf: reduce memory churn on predict perf: reduce prediction time by 20% Jun 11, 2020
@imatiach-msft imatiach-msft changed the title perf: reduce prediction time by 20% perf: reduce lightgbm prediction time by 20% Jun 11, 2020
@congnt-dsv
Copy link

@imatiach-msft When can you continue with this PR?

@mhamilton723 mhamilton723 requested a review from svotaw as a code owner November 17, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants