Skip to content

Comments

Spark Serving v2#530

Merged
mhamilton723 merged 4 commits intomicrosoft:masterfrom
mhamilton723:serving-refactor
Apr 6, 2019
Merged

Spark Serving v2#530
mhamilton723 merged 4 commits intomicrosoft:masterfrom
mhamilton723:serving-refactor

Conversation

@mhamilton723
Copy link
Contributor

No description provided.

@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

PASS Pass! — The build has succeeded. (c01b01b5)

MMLSpark 0.16.dev14+2.gc01b01b

This is a build for Github PR #530, changes:


idRow.update(1, null)
val idRow = new GenericInternalRow(3)
idRow.update(0, null)
idRow.update(1, UTF8String.fromString(id.toString))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UTF8String.fromString(id.toString) looks expensive. what type is id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its a long, for some reason Spark's internal row construction needs this UTF8 string instead of a regular string. The HTTP Source is mainly good for debugging though and will be deprecated for v2 stuff soon though

@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

PASS Pass! — The build has succeeded. (653af78b)

MMLSpark 0.16.dev14+4.g653af78

This is a build for Github PR #530, changes:


@mhamilton723 mhamilton723 merged commit 5d3aed1 into microsoft:master Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants