test: add 60 unit tests for automl, codegen, utils, and VW modules#2498
Open
BrendanWalsh wants to merge 3 commits intomasterfrom
Open
test: add 60 unit tests for automl, codegen, utils, and VW modules#2498BrendanWalsh wants to merge 3 commits intomasterfrom
BrendanWalsh wants to merge 3 commits intomasterfrom
Conversation
Add 7 new test files with 60 tests covering previously-untested source files: - AutoML: HyperparamBuilder (IntRange, DoubleRange, FloatRange, LongRange, DiscreteHyperParam, HyperParamUtils), DefaultHyperparams (all 6 classifier defaults), EvaluationUtils (metric-operator mapping), ParamSpace (GridSpace, RandomSpace, Dist) - Codegen: GenerationUtils (indent, camelToSnake) - Utils: ModelEquality (jaccardSimilarity) - VW: VectorUtils (sortAndDistinct with collision handling) All tests are pure unit tests with no external service dependencies.
|
Hey @BrendanWalsh 👋! We use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
To test your commit locally, please follow our guild on building from source. |
Add 8 new test files: - Codegen: CodegenConfig (directory derivation, constants), DefaultParamInfo (param type mapping for all 16+ param types) - HTTP: RESTHelpers retry logic (success, retry-then-succeed, exhaustion) - Stages: Trie data structure (put/get/mapText/overlapping keys), Cacher (cache/disable), UnicodeNormalize (NFKD/case), TextPreprocessor (substring replacement via Trie) - LightGBM: DatasetUtils (countCardinality, getArrayType, validateGroupColumn) Pure unit tests run without SparkSession. Spark-dependent tests (Cacher, UnicodeNormalize, TextPreprocessor) use small in-memory DataFrames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
Follow-up to #2497 — continued coverage improvement.
What changes were proposed in this pull request?
Adds 16 new test files with 118 unit tests covering previously-untested source files across core, VW, and LightGBM modules:
How was this patch tested?
All 118 tests compile and pass locally. Mix of pure unit tests (no SparkSession) and lightweight Spark tests using small in-memory DataFrames. No external service dependencies.
Does this PR introduce any user-facing change?
No — test-only change.
New Dependencies
None.