Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change to use mwc token in tenant setting check #2300

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

lhrotk
Copy link
Contributor

@lhrotk lhrotk commented Oct 15, 2024

Related Issues/PRs

Need to use mwc token when accessing fabric openai endpoints, AAD token will be banned and also AAD is not enough to show workspace permission

What changes are proposed in this pull request?

Replace AAD token with MWC token

How is this patch tested?

Manual

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.

@lhrotk
Copy link
Contributor Author

lhrotk commented Oct 15, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.48%. Comparing base (0ad58b7) to head (d1ad58a).

Files with missing lines Patch % Lines
.../azure/synapse/ml/fabric/OpenAIFabricSetting.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2300      +/-   ##
==========================================
- Coverage   84.63%   84.48%   -0.15%     
==========================================
  Files         326      326              
  Lines       16769    16769              
  Branches     1502     1480      -22     
==========================================
- Hits        14192    14168      -24     
- Misses       2577     2601      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lhrotk lhrotk changed the title fix: change to use mwc token for tenant setting check fix: change to use mwc token in tenant setting check Oct 15, 2024
@mhamilton723 mhamilton723 merged commit 99233e7 into microsoft:master Oct 16, 2024
68 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants