Open
Conversation
Like DevCom URLs, everything after the number is ignored.
| // Entry: | ||
| // LPCWSTR LocaleName - locale context for the comparison. | ||
| // DWORD dwCmpFlags - see https://aka.ms/stl/comparestringex | ||
| // DWORD dwCmpFlags - https://learn.microsoft.com/windows/win32/api/stringapiset/nf-stringapiset-comparestringex |
Contributor
There was a problem hiding this comment.
These two URLs are different from the other two
Member
Author
There was a problem hiding this comment.
Yes, there were two pairs of URLs. I replaced each with what they expand to, then dropped the /en-us component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today I learned that our documentation team recommends omitting locale/version information from URLs (unless linking to a specific version is desired). So while I generally prefer to avoid URLs that get rewritten (except when intentionally using a redirector), following this recommendation is desirable and makes the URLs a bit shorter. I've manually verified that all of these updated URLs still work.
(https://learn\.microsoft\.com/)en-us/([^ ?#]+)(?:\?view=([^ #]+))?=>$1$2?tabs=powershell.There's one URL which still incurs a major redirect, where
.github/ISSUE_TEMPLATE/question.mdcites https://help.github.com/en/github/managing-your-work-on-github/creating-a-permanent-link-to-a-code-snippet which redirects to https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-a-permanent-link-to-a-code-snippet, but that exceeds 120 columns so I'm not changing it (and it isn't worth the additional confusion of linking to the parent doc node).