-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<tuple>: tuple_cat for tuple-like types #461
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually implement #260 since we use _STD get<_Kx>
on line 951 which only supports array
, pair
, and tuple
. I think we need to arrange for that to be the qualified std::get
for standard types and unqualified get
for non-standard types.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Hi there, @ArtemSarmini are you still working on this? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commenter does not have sufficient privileges for PR 461 in repo microsoft/STL |
Pull request contains merge conflicts. |
It looks like @ArtemSarmini hasn't had time to look into this for the last couple of years - totally understandable, since the maintainer team was also incredibly busy! 😹 I'd like to ensure that the original contributor gets credit for looking into this issue, even if they've moved on to other things, so I'll pick up this PR (which is now our oldest active PR and the only triple-digit one). I believe the main issues are:
Thus I believe that different code changes are needed, and will force-push this PR to start from today's |
Commenter does not have sufficient privileges for PR 461 in repo microsoft/STL |
Actually, the Azure Pipelines bot is acting weird here; I will instead create a fresh PR and use Co-authored-by for crediting. |
Description
Closes #260. I also replaced recursive impl of
_View_as_tuple
for arrays withindex_sequence
.Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Ugly
as perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.