Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<memory>: Workaround for MSVC bug on operator<=> (shared_ptr only) #3647

Merged
merged 2 commits into from
Apr 14, 2023
Merged

<memory>: Workaround for MSVC bug on operator<=> (shared_ptr only) #3647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e39bb62
Workaround for `operator<=>` for `shared_ptr`
frederick-vs-ja Apr 10, 2023
49362f3
Missing `;`
frederick-vs-ja Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions stl/inc/memory
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1883,7 +1883,12 @@ _NODISCARD bool operator==(const shared_ptr<_Ty1>& _Left, const shared_ptr<_Ty2>
#if _HAS_CXX20
_EXPORT_STD template <class _Ty1, class _Ty2>
_NODISCARD strong_ordering operator<=>(const shared_ptr<_Ty1>& _Left, const shared_ptr<_Ty2>& _Right) noexcept {
#if !defined(__EDG__) && !defined(__clang__) // TRANSITION, DevCom-10334808
using _Common_ptr_t = decltype(false ? _Left.get() : _Right.get());
return static_cast<_Common_ptr_t>(_Left.get()) <=> static_cast<_Common_ptr_t>(_Right.get());
#else // ^^^ workaround / no workaround vvv
return _Left.get() <=> _Right.get();
#endif // ^^^ no workaround ^^^
}
#else // ^^^ _HAS_CXX20 / !_HAS_CXX20 vvv
template <class _Ty1, class _Ty2>
Expand Down
12 changes: 12 additions & 0 deletions tests/std/tests/P1614R2_spaceship/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,6 +1021,18 @@ void ordering_test_cases() {
spaceship_test<std::strong_ordering>(p1, p3, p5);
spaceship_test<std::strong_ordering>(p1, nullptr, p4);
}
{ // shared_ptr, heterogeneous
std::shared_ptr<const int> p1{};
std::shared_ptr<void> p2{};
std::shared_ptr<volatile int> p3{};

std::shared_ptr<int> p4{new int};

spaceship_test<std::strong_ordering>(p1, p2, p4);
spaceship_test<std::strong_ordering>(p1, p3, p4);
spaceship_test<std::strong_ordering>(p2, p3, p4);
spaceship_test<std::strong_ordering>(p1, nullptr, p4);
}
{ // slice
std::slice a1(2, 3, 4);
std::slice a2(2, 3, 4);
Expand Down