Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use if constexpr dispatch for _Pass_fn #3389

Merged
merged 2 commits into from
Feb 11, 2023
Merged

Use if constexpr dispatch for _Pass_fn #3389

merged 2 commits into from
Feb 11, 2023

Conversation

CaseyCarter
Copy link
Member

No description provided.

@CaseyCarter CaseyCarter added the throughput Must compile faster label Feb 5, 2023
@CaseyCarter CaseyCarter requested a review from a team as a code owner February 5, 2023 05:28
miscco
miscco reviewed Feb 5, 2023
View reviewed changes
stl/inc/xutility Outdated Show resolved Hide resolved
stl/inc/xutility Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter mentioned this pull request Feb 6, 2023
Closed
miscco
miscco approved these changes Feb 6, 2023
View reviewed changes
stl/inc/xutility Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

Thanks for removing the TRANSITION comment for VSO-386225 "[VSFeedback] C2 won't inline function pointers - Was: excessive Codegen on function_view" (linked to DevCom-16882). I kept seeing this when scanning TRANSITION comments but was never sure of the status of needing _Pass_fn.

@StephanTLavavej StephanTLavavej self-assigned this Feb 10, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 3218823 into microsoft:main Feb 11, 2023
@StephanTLavavej
Copy link
Member

Thanks for noticing and simplifying this widely used helper function! 😻 🎉 😸

@CaseyCarter CaseyCarter deleted the pass_fn branch February 11, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
throughput Must compile faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CaseyCarter @StephanTLavavej @miscco @strega-nil-ms