Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LLVM submodule #3344

Merged
merged 2 commits into from
Jan 22, 2023
Merged

Update LLVM submodule #3344

merged 2 commits into from
Jan 22, 2023

Conversation

CaseyCarter
Copy link
Member

Update SHA and skip list(s), and some other changes:

  • Tell features.py that we support ja_JP.UTF-8. Some of the libcxx <format>/chronat tests use that locale.
  • Build libcxx tests with /utf-8. They write tests with the expectation that the source and execution character sets are both UTF-8, we should make it so to avoid failures.
  • Build libcxx tests with C6262 "Excessive stack size" disabled. A few tests use a ton of stack, and run just fine. It's not product code, and IMO not worth our time or theirs to rewrite such tests.

@CaseyCarter
Update LLVM submodule
4c2addc 
Update SHA and skip list(s), and some other changes:
* Tell `features.py` that we support `ja_JP.UTF-8`. Some of the libcxx `<format>`/`chronat` tests use that locale.
* Build libcxx tests with `/utf-8`. They write tests with the expectation that the source and execution character sets are both UTF-8, we should make it so to avoid failures.
* Build libcxx tests with [C6262 "Excessive stack size"](https://learn.microsoft.com/en-us/cpp/code-quality/c6262?view=msvc-170) disabled. A few tests use a ton of stack, and run just fine. It's not product code, and IMO not worth our time or theirs to rewrite such tests.
@CaseyCarter CaseyCarter added the test Related to test code label Jan 12, 2023
@CaseyCarter CaseyCarter requested a review from a team as a code owner January 12, 2023 05:27
StephanTLavavej
StephanTLavavej reviewed Jan 12, 2023
View reviewed changes
tests/libcxx/expected_results.txt Outdated Show resolved Hide resolved
tests/libcxx/expected_results.txt Outdated Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

Looks good - verified zero divergence between expected_results.txt and skipped_tests.txt. Although it pained me to do so, I had to reset testing to fix a comment typo (also clarified a comment since I was pushing changes anyways).

Thanks for this big update, I know how much work it is! 😻

@CaseyCarter CaseyCarter mentioned this pull request Jan 12, 2023
Closed
strega-nil-ms
strega-nil-ms approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@StephanTLavavej StephanTLavavej self-assigned this Jan 21, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 1081580 into microsoft:main Jan 22, 2023
@StephanTLavavej
Copy link
Member

Thanks again for this major llvm-project update!

😻 🐈‍⬛ 🎉

@StephanTLavavej StephanTLavavej mentioned this pull request Jan 22, 2023
Merged
@CaseyCarter CaseyCarter deleted the llvm branch January 22, 2023 19:32
@StephanTLavavej StephanTLavavej mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
test Related to test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CaseyCarter @StephanTLavavej @strega-nil-ms