Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolset update: VS 2022 17.5 Preview 2 #3288

Merged
merged 9 commits into from
Dec 15, 2022
Merged

Toolset update: VS 2022 17.5 Preview 2 #3288

merged 9 commits into from
Dec 15, 2022

Conversation

StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Dec 15, 2022 •
edited
Loading

  • Updated dependencies.
    • Updated build compiler to VS 2022 17.5 Preview 2 (now required).
    • Updated CMake to 3.25 (now required).
    • Updated Python to 3.11.1.
  • New 1ES Hosted Pool, containing Patch Tuesday.
  • Use PowerShell 7.3.1 while preparing the VM.
  • Remove workaround for VSO-1655459 "C1XX Assertion failed ... in ParseTree.cpp, with C++23 zip_view".
  • Remove workaround for VSO-1675318 "EDG __builtin_memcmp misbehavior, part 3".
  • Add workaround for VSO-1705654 "Standard Library Modules: /analyze ICE".
  • Add workaround for CMake-24249 'Error when requiring CMake 3.25: "MSVC_DEBUG_INFORMATION_FORMAT value 'ProgramDatabase' not known for this ASM_MASM compiler"'.

@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Dec 15, 2022
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner December 15, 2022 04:21
@fsb4000
Copy link
Contributor

fsb4000 commented Dec 15, 2022 •
edited
Loading

Why didn't https://github.com/microsoft/STL/tree/main/tests/std/tests/P1502R1_standard_library_header_units find #3287 ?

@StephanTLavavej
Copy link
Member Author

#3287 repros only with /ZI (debug info for edit and continue), which the STL's test suite doesn't use at all, so that explains why I didn't see it in this toolset update.

@StephanTLavavej StephanTLavavej self-assigned this Dec 15, 2022
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 67d89ce into microsoft:main Dec 15, 2022
@StephanTLavavej StephanTLavavej deleted the vs-17.5p2 branch December 15, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
infrastructure Related to repository automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StephanTLavavej @fsb4000 @CaseyCarter @strega-nil-ms