Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement P2499R0: string_view Range Constructor Should Be explicit #2947

Merged
merged 5 commits into from
Jul 28, 2022
Merged

Implement P2499R0: string_view Range Constructor Should Be explicit #2947

merged 5 commits into from
Jul 28, 2022

Conversation

sam20908
Copy link
Contributor

@sam20908 sam20908 commented Jul 26, 2022 •
edited
Loading

Fixes #2935

@sam20908 sam20908 requested a review from a team as a code owner July 26, 2022 19:39
@sam20908 sam20908 changed the title Implement P2499R0: string_view Range Constructor Should Be explicit Implement P2499R0: string_view Range Constructor Should Be explicit Jul 26, 2022
@CaseyCarter CaseyCarter added the cxx23 C++23 feature label Jul 26, 2022
CaseyCarter
CaseyCarter requested changes Jul 26, 2022
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add an entry for P2499R0 string_view Range Constructor Should Be explicit in the "[features] controlled by _HAS_CXX23" section of <yvals_core.h>" (Yes, this isn't much of a feature, but that's the process.) somewhere around line 317. (They're ordered by proposal number.)

@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@StephanTLavavej StephanTLavavej mentioned this pull request Jul 26, 2022
Closed
@StephanTLavavej
Copy link
Member

Perfect, thanks!

@StephanTLavavej StephanTLavavej self-assigned this Jul 27, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 6db1eb4 into microsoft:main Jul 28, 2022
@StephanTLavavej
Copy link
Member

Thanks for implementing this feature, following the original one you implemented! 😻 ✅ 🚀

@strega-nil-ms strega-nil-ms mentioned this pull request Aug 9, 2022
Closed
fsb4000 pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
@sam20908 @fsb4000
Implement P2499R0: string_view Range Constructor Should Be `explici…
9177431 
…t` (microsoft#2947)
@fsb4000 fsb4000 mentioned this pull request Sep 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx23 C++23 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P2499R0 string_view Range Constructor Should Be explicit
3 participants
@sam20908 @StephanTLavavej @CaseyCarter