Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<complex>: avoid unnecessary conversion of real arguments to complex #2855

Merged
merged 3 commits into from
Jul 14, 2022
Merged

<complex>: avoid unnecessary conversion of real arguments to complex #2855

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c55dad6
Swap arguments in commutative mixed complex/real operations to avoid …
MattStephanson Jul 11, 2022
b3c2dbc
review feedback
MattStephanson Jul 11, 2022
89f9054
Call `op=` for `complex - T` and `complex / T`.
StephanTLavavej Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions stl/inc/complex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1408,8 +1408,8 @@ _NODISCARD _CONSTEXPR20 complex<_Ty> operator+(const complex<_Ty>& _Left, const

template <class _Ty>
_NODISCARD _CONSTEXPR20 complex<_Ty> operator+(const _Ty& _Left, const complex<_Ty>& _Right) {
complex<_Ty> _Tmp(_Left);
_Tmp += _Right;
complex<_Ty> _Tmp(_Right);
_Tmp += _Left;
return _Tmp;
}

Expand Down Expand Up @@ -1451,8 +1451,8 @@ _NODISCARD _CONSTEXPR20 complex<_Ty> operator*(const complex<_Ty>& _Left, const

template <class _Ty>
_NODISCARD _CONSTEXPR20 complex<_Ty> operator*(const _Ty& _Left, const complex<_Ty>& _Right) {
complex<_Ty> _Tmp(_Left);
_Tmp *= _Right;
complex<_Ty> _Tmp(_Right);
_Tmp *= _Left;
return _Tmp;
}

Expand Down