run memory leaks tests only with Debug CRT #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/std/tests/Dev11_0485243_condition_variable_crash/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Jul 12, 2022
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Jul 14, 2022
|
Thanks for slightly accelerating test runs! 🐇 🐆 🏇 |
fsb4000
added a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the tests while changing
<meow.h>to<cmeow>.Based on the comment: #2763 (comment)
We also have another test with
_CrtDumpMemoryLeaks:tests\std\tests\P0718R2_atomic_smart_ptrs\test.cppBut it seems the test is checking more things and Release CRT tests make sense...