Add missing implicit SFINAE constraints #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also speculatively implements LWG-3627: Inconsistent specifications for std::make_optional overloads
which hasn't been accepted at this moment.
tests/std/tests/GH_002299_implicit_sfinae_constraints/test.compile.pass.cpp
Show resolved
Hide resolved
tests/std/tests/GH_002299_implicit_sfinae_constraints/test.compile.pass.cpp
Show resolved
Hide resolved
tests/std/tests/GH_002299_implicit_sfinae_constraints/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_002299_implicit_sfinae_constraints/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_002299_implicit_sfinae_constraints/test.compile.pass.cpp
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Mar 15, 2022
|
Thanks! Product code looked perfect, so I went ahead and pushed minor test changes (the most significant of which was ensuring that the custom type traits can return both |
CaseyCarter
approved these changes
Mar 17, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for improving the library's conformance to this invisible Standardese! 😹 👓 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214
Fixes #2299
Also speculatively implements LWG-3627.