Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup comments and clang-formatting #2136

Merged

Conversation

StephanTLavavej
Copy link
Member

This is structured as a series of commits for easier reviewing. It addresses code review feedback from GH-2064 and is largely a followup to that toolset update's introduction of clang-format 12.

  • Cite VSO-586813 "T^ is not allowed in a union" to address code review feedback.
  • Improve clang-format to address code review feedback.
  • Enable clang-format with literally no changes.
  • Shrink // clang-format off regions, literally no changes.
  • Enable clang-format with whitespace-only changes.
  • Enable clang-format with // wrapping, only whitespace changes.
  • Enable clang-format with // wrapping.
  • Enable clang-format for improved formatting.
  • Add spaces after // begins a comment.
  • Detach switch comments.
  • Drop unnecessary comments for unnamed parameters.

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Aug 18, 2021
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner August 18, 2021 20:10
Copy link
Member

@barcharcraz barcharcraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

today I learned about the // line wrapping thing in clang-format

@StephanTLavavej
Copy link
Member Author

I'm mirroring this to an MSVC-internal PR. Please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 6d2f8b0 into microsoft:main Aug 27, 2021
@StephanTLavavej StephanTLavavej deleted the cleanups1-comments-formatting branch August 27, 2021 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants