-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup comments and clang-formatting #2136
Merged
StephanTLavavej
merged 11 commits into
microsoft:main
from
StephanTLavavej:cleanups1-comments-formatting
Aug 27, 2021
Merged
Cleanup comments and clang-formatting #2136
StephanTLavavej
merged 11 commits into
microsoft:main
from
StephanTLavavej:cleanups1-comments-formatting
Aug 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
CaseyCarter
approved these changes
Aug 19, 2021
barcharcraz
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
today I learned about the // line wrapping thing in clang-format
I'm mirroring this to an MSVC-internal PR. Please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is structured as a series of commits for easier reviewing. It addresses code review feedback from GH-2064 and is largely a followup to that toolset update's introduction of clang-format 12.
T^
is not allowed in aunion
" to address code review feedback.// clang-format off
regions, literally no changes.//
wrapping, only whitespace changes.//
wrapping.//
begins a comment.