Skip to content

P1518R2 Stop Overconstraining Allocators In Container Deduction Guides#2032

Merged
StephanTLavavej merged 14 commits intomicrosoft:mainfrom
fsb4000:fix1974
Aug 27, 2021
Merged

P1518R2 Stop Overconstraining Allocators In Container Deduction Guides#2032
StephanTLavavej merged 14 commits intomicrosoft:mainfrom
fsb4000:fix1974

Conversation

@fsb4000
Copy link
Copy Markdown
Contributor

@fsb4000 fsb4000 commented Jul 1, 2021 •
edited
Loading

Fixes #1974

https://wg21.link/P1518R2

I have a few questions:

  1. It works with clang-cl and doesn't work with cl. Is it me or the compiler has a bug?

  2. libc++ did it in C++17: llvm/llvm-project@dd15c27

Is it ok do same for compatibility with libc ++ tests?

@fsb4000 fsb4000 requested a review from a team as a code owner July 1, 2021 03:02
@StephanTLavavej StephanTLavavej changed the title implement P1518R2 P1518R2 Stop Overconstraining Allocators In Container Deduction Guides Jul 1, 2021
@StephanTLavavej StephanTLavavej added the cxx23 C++23 feature label Jul 1, 2021
miscco
miscco reviewed Jul 1, 2021
View reviewed changes
Comment thread tests/std/tests/P1518R2_stop_overconstraining_allocators/test.compile.pass.cpp Outdated
miscco
miscco approved these changes Jul 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fsb4000 @miscco
omit unused parameter
d6cb3fc 
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@gmail.com>
@fsb4000

This comment has been minimized.

Sign in to view
@fsb4000

This comment has been minimized.

Sign in to view
@miscco

This comment has been minimized.

Sign in to view
@fsb4000

This comment has been minimized.

Sign in to view
@fsb4000

This comment has been minimized.

Sign in to view
@fsb4000

This comment has been minimized.

Sign in to view
@StephanTLavavej

This comment has been minimized.

Sign in to view
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 12, 2021
Merged
@StephanTLavavej

This comment has been minimized.

Sign in to view
@StephanTLavavej StephanTLavavej self-assigned this Aug 18, 2021
StephanTLavavej
StephanTLavavej requested changes Aug 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this CTAD paper!

Comment thread stl/inc/queue
Comment thread stl/inc/deque Outdated
Comment thread stl/inc/deque Outdated
Comment thread tests/std/tests/P1518R2_stop_overconstraining_allocators/test.compile.pass.cpp Outdated
Comment thread tests/std/tests/P1518R2_stop_overconstraining_allocators/test.compile.pass.cpp
Comment thread tests/std/tests/P1518R2_stop_overconstraining_allocators/test.compile.pass.cpp
@StephanTLavavej
Copy link
Copy Markdown
Member

StephanTLavavej commented Aug 26, 2021

I'm mirroring this to an MSVC-internal PR. Changes can still be pushed during final review, but please notify me if that happens.

@StephanTLavavej
Copy link
Copy Markdown
Member

StephanTLavavej commented Aug 26, 2021

Had to push a change to get this to pass in the internal test harness, which always wants to link and run tests (even if they're named test.compile.pass.cpp). Dropping extern from pmr::monotonic_buffer_resource mr; was sufficient, as it has a default constructor.

@CaseyCarter CaseyCarter removed their assignment Aug 26, 2021
@StephanTLavavej StephanTLavavej merged commit d46c27f into microsoft:main Aug 27, 2021
@StephanTLavavej
Copy link
Copy Markdown
Member

StephanTLavavej commented Aug 27, 2021

Thanks for improving CTAD, one of my favorite features! 😻 🚀 🎉

@fsb4000 fsb4000 deleted the fix1974 branch August 27, 2021 12:49
@StephanTLavavej StephanTLavavej mentioned this pull request Dec 10, 2021
Merged
@frederick-vs-ja frederick-vs-ja mentioned this pull request Oct 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@miscco miscco miscco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

cxx23 C++23 feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

P1518R2 Stop Overconstraining Allocators In Container Deduction Guides

4 participants

@fsb4000 @miscco @StephanTLavavej @CaseyCarter