Comparisons with nullable types #558

Activity

1. celi commented on Nov 30, 2023

   

   celi

   on Nov 30, 2023

   Last edited by celi

   Author

   More actions

   I found that FastExpressionCompiler changes this behavior.

   Changing line
   

   RulesEngine/src/RulesEngine/ExpressionBuilders/RuleExpressionParser.cs

   Line 60 in 9bcf4f3

   return wrappedExpression.CompileFast();

   
   to

   return wrappedExpression.Compile();
   

   fix this problem.

   This is bug for me.
2. celi commented on Nov 30, 2023

   

   celi

   on Nov 30, 2023

   Author

   More actions

   Linked dadhi/FastExpressionCompiler#380
3. celi

   changed the title [-]Comparisons with nullable values[/-] [+]Comparisons with nullable types[/+] on Dec 5, 2023
4. abbasc52 commented on Jan 3, 2024

   

   Abbas Cyclewala (abbasc52)

   on Jan 3, 2024

   More actions

   celi i can maybe add option to disable fast compile if needed, it will be a tradeoff between performance vs accuracy
   Would that work for you?
5. celi commented on Jan 3, 2024

   

   celi

   on Jan 3, 2024

   Author

   More actions

   Abbas Cyclewala (@abbasc52) Yes, please.
   I didn't test decrease of performance without FastExpressionCompiler yet, but I plan to do that. It will be easier with this switch.
6. abbasc52 commented on Jan 12, 2024

   

   Abbas Cyclewala (abbasc52)

   on Jan 12, 2024

   More actions

   celi can you share complete sample code to reproduce this issue?
7. celi commented on Jan 12, 2024

   

   celi

   on Jan 12, 2024

   Author

   More actions

   Abbas Cyclewala (@abbasc52) https://github.com/celi/MsRulesEngineCompareWithNullBug

   just run dotnet run in project folder
8. Abbas Cyclewala (abbasc52)

   closed this as completedin #570on Jan 12, 2024