Skip to content

Comments

Add .xlsm as known file type#408

Merged
jtarquino merged 2 commits intomicrosoft:masterfrom
Periscope-NZ:master
Jun 26, 2023
Merged

Add .xlsm as known file type#408
jtarquino merged 2 commits intomicrosoft:masterfrom
Periscope-NZ:master

Conversation

@Periscope-NZ
Copy link
Contributor

@Periscope-NZ Periscope-NZ commented Jun 9, 2023

Add .xlsm (Microsoft Excel macro-enabled spreadsheet) to the type lookup. XLSM files are supported by Power BI but until now they could not be uploaded, refer to issue #349.

Fixes #349.

Changes proposed in this pull request:

  • Adds a single line to Get-ItemType.ps1 for the .xlsm file type
  • Minor reformat of layout (spacing) for neatness

How to test this code:

  • Create an .xlsm file in Excel, save it as C:\Temp\Just_a_test.xlsm
  • Upload the file using Write-RsRestCatalogItem -ReportPortalURI $youruri -Path 'C:\Temp\Just_a_test.xlsm' -RsFolder $DestFolder
    (Previously this would fail with an error message - (400) Bad Request. After this change to Get-ItemType.ps1 it seems to run without any issues.)

Has been tested on (remove any that don't apply):

  • Powershell 5.1
  • Windows Server 2016

Add .xlsm (Microsoft Excel macro-enabled spreadsheet) to the type lookup. XLSM files are supported by Power BI but until now they could not be uploaded, refer to issue microsoft#349
@Periscope-NZ
Copy link
Contributor Author

@microsoft-github-policy-service agree

@Periscope-NZ
Copy link
Contributor Author

So, how many weeks does it usually take to approve a single-line change to the code?

@jtarquino jtarquino merged commit e41048c into microsoft:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write-RsRestCatalogItem does not accept xslm files

2 participants