Added code to handle restarting RS service with alternate credential #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtarquino
reviewed
May 10, 2019
| do { | ||
| $service = Get-WmiObject @getServiceParams | ||
| Start-Sleep -Seconds 1 | ||
| } until ($service.State -eq 'Stopped') |
There was a problem hiding this comment.
I would do a timeout or number of retries , otherwise it had a change to get stuck here in a infinite loop if the service don't stop
There was a problem hiding this comment.
Good idea, I considered that. However, in the current implementation WaitForStatus will wait indefinitely, so I was just mimicking the same behavior.
What do you think is a reasonable amount of time/retries?
There was a problem hiding this comment.
I would think a couple of minutes (120 retries) should be good enough
In reply to: 282992334 [](ancestors = 282992334)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #228 .
Changes proposed in this pull request:
How to test this code:
Assuming that
adminuseruser has access to the computer SSRS and the user running the command does not:Has been tested on (remove any that don't apply):