This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Review notes for combined Oct/Nov meeting. #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2020
guenp
reviewed
Nov 9, 2020
|
|
||
| - Modify QInt → QSignedInt? ControlledOnInt could be confusing otherwise. | ||
| - Add https://github.com/microsoft/qsharp-language/pull/41 as related issue. | ||
| - What are the disadvantages to making parallel Microsoft.Quantum.Numerics namespace? Mainly about explaining change to user. |
There was a problem hiding this comment.
Suggested change
| - What are the disadvantages to making parallel Microsoft.Quantum.Numerics namespace? Mainly about explaining change to user. | |
| - What are the disadvantages to making parallel `Microsoft.Quantum.Numerics` namespace? Mainly about explaining change to user. |
msoeken
approved these changes
Nov 10, 2020
Thanks for looking over the notes. As discussed at the meeting, that concern is covered by the |
Co-authored-by: Guen P <guenp@microsoft.com>
Co-authored-by: Guen P <guenp@microsoft.com>
cgranade
added
the
automerge
guenp
approved these changes
Nov 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds review notes from the combined October / November 2020 Q# API review meeting. A discussion thread will be opened shortly and linked to from this PR.