Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Add DevSkim scanning #778

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Add DevSkim scanning #778

merged 2 commits into from
Apr 22, 2022

Conversation

anjbur
Copy link
Contributor

@anjbur anjbur commented Apr 22, 2022

Adds a new GitHub action to run the Microsoft DevSkim tool. This will integrate with the Security Issues view and scan PRs for new potential issues.

@tcNickolas
Copy link
Member

@anjbur Can you clarify what kind of issues are going to be detected and reported, and how is this going to look - is this an extra CI build job that will fail if the PR introduces new issues?

@anjbur
Copy link
Contributor Author

anjbur commented Apr 22, 2022

@tcNickolas It's an additional compliance tool to catch any potential security alerts. It runs a static code analysis and will create a failing PR check if any new issues are introduced by a PR. You can see the added CI checks on this PR: one for the code action to run (DevSkim / DevSkim (pull_request)) and one with the results (Code scanning results / devskim). Any alerts (against main or a PR) are also visible though the Code Scanning Alerts section under the Security tab!

Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I see the two new checks on the pull request passing so we're in a good place to start using them.

@tcNickolas tcNickolas merged commit bf09e48 into main Apr 22, 2022
@tcNickolas tcNickolas deleted the anburton/add-devskim branch April 22, 2022 23:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants