Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Basic Gates Workbook Task 2.5 #758

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Conversation

tonyholdroyd112
Copy link
Contributor

Basic Gates Workbook Task 2.5

@tonyholdroyd112 tonyholdroyd112 marked this pull request as ready for review February 26, 2022 12:06
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I did the customary cleanup - there was an issue with endianness of the Fredkin gate matrix, the swapped elements in the matrix didn't match the ones in the column vectors. Dirac notation has its advantages when dealing with endianness, as long as you don't collapse bitstrings into integers :-)

And this marks the completion of the BasicGates workbook! Thank you so much!

@tcNickolas tcNickolas merged commit 3242fe0 into microsoft:main Feb 28, 2022
@TonyHoldroyd
Copy link
Contributor

TonyHoldroyd commented Mar 1, 2022 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants