Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Basic Gates Workbook Task 2.4 #756

Merged
merged 2 commits into from
Feb 26, 2022
Merged

Basic Gates Workbook Task 2.4 #756

merged 2 commits into from
Feb 26, 2022

Conversation

tonyholdroyd112
Copy link
Contributor

Second attempt

@tonyholdroyd112 tonyholdroyd112 marked this pull request as ready for review February 25, 2022 22:26
tcNickolas
tcNickolas approved these changes Feb 26, 2022
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I did a bit of cleanup, mostly fixed the order of \theta and \eta in the column vector representation of the state - an easy typo to make :-)

Thank you!

@tcNickolas tcNickolas merged commit 12661af into microsoft:main Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tcNickolas tcNickolas tcNickolas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyholdroyd112 @tcNickolas @TonyHoldroyd