Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Basic Gates Workbook Tasks 2p1, 2p2 #748

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Basic Gates Workbook Tasks 2p1, 2p2 #748

merged 3 commits into from
Feb 16, 2022

Conversation

tonyholdroyd112
Copy link
Contributor

Basic Gates Workbook Tasks 2p1, 2p2 from new github a/c

@tcNickolas
Copy link
Member

I'm not sure if you want me to look at this PR yet - the CI build failure is a simple typo, the solution line CNOT(qs[0], q[1]); uses q instead of qs for the second argument, fixing it should fix the failure.

@tonyholdroyd112
Copy link
Contributor Author

Thanks Mariia, I really should have spotted that typo that crept in somehow, but all's well now and it's ready for your perusal

@tonyholdroyd112 tonyholdroyd112 marked this pull request as ready for review February 11, 2022 20:25
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I did a bit of cleanup, and then realized that I didn't run the spellchecker on the last couple of solutions, so I did that - that's why you see some changes of the earlier workbook.

Thank you!

@tcNickolas tcNickolas merged commit af06ca6 into microsoft:main Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants