-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Switched to a new dump functionality exposed by IQ#. #727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but would be good to get @tcNickolas' review as code owner as well. One thing I'll point out quickly, though, is that as written in this PR, the %kata
magic command won't support histogram views for displayable states. I think that was already the case before this PR, so not a regression so much as a known limitation.
@kuzminrobin I'm not very familiar with the katas magic part of code, @anjbur usually helps me with reviews on them. Can you please provide a bit of context on this change? Are there going to be any user-facing behavior changes? What about @cgranade's comment on #688? (Also, it looks like this PR supersedes #688 - could you please close the other PR to keep things more organized?) |
The long and short of it is that the full-state simulator used a different means of reporting diagnostics than other simulators (e.g.: Toffoli, open-systems). As part of developing the sparse simulator, the full-state simulator has been updated to use the same approach to diagnostics reporting, allowing a lot of duplicate code to be removed from both the qsharp-runtime and iqsharp repos. This PR makes sure that the new unified approach works here as well.
When using |
This change stops calling the functionality (in IQ#) that is being removed as a simplification of the Dump functionality in QuantumSimulator.
No. Nothing that the user's code could be relying on. I added a reply there that the note has been resolved in this repeated attempt.
Done. Thanks for the reminder! ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cgranade Right, this bug! I thought initially that your comment was about the measurement probability bars shown in regular DumpMachine output, thank you for clarifying!
That was my one concern, I'll trust you folks on the syntax of the change :-) Approving, I'll let you update the branch to latest and merge when the time is right (not sure if it needs to go in sync with the other two PRs)
Simplified the Dump functionality for QuantumSimulator and the functionality use in IQSharp.
This is a part of the set of 3 PRs:
Q#RT side,
IQ#,
Katas.