This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Clean up measurement workbook #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Measurements/Workbook_Measurements.ipynb
tcNickolas
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
Looks good! I did a final round of polish, changing the links to specific gates to SingleQubitGates notebook (a tutorial is a better source than a kata or docs) and catching a typo in 1.4 (the sign of the rotation angle has to be different in the gate and its adjoint, since R gates are not self-adjoint).
Thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#326
@tcNickolas my suggestions for the Measurement workbook.