This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Adding Linear Algebra workbook #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Mariia Mykhailova <michaylova@gmail.com>
Also fix testing harness for task 1 and make tests for task 14 stronger
tcNickolas
approved these changes
Jan 19, 2020
There was a problem hiding this comment.
I did a round of cleanup on the workbook. As I was doing smaller changes to phrasings and explanations I realized that the testing harness for task 1 could be improved and that the solution I suggested for task 14 is incorrect, so I fixed those issues as well (together with stronger test set for task 14). Looks great now!
Sorry for the delay reviewing the PR, and thank you for this massive work!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#208