Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Variational Quantum Eigensolver sample notebooks #673

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

guenp
Copy link
Contributor

@guenp guenp commented Jun 2, 2022

Add VQE notebooks with samples for IonQ and Quantinuum

Guen Prawiroatmodjo added 2 commits June 2, 2022 15:54
add README

Update README.md

Update VQE-qiskit-hydrogen-ionq-sim.ipynb

respond to code review comments

update notebooks

Update samples/azure-quantum/variational-quantum-eigensolver/VQE-qiskit-hydrogen-ionq-sim.ipynb

Co-authored-by: Cassandra Granade <chgranad@microsoft.com>

add in link to qiskit textbook

add pip install, formatting and comments

snake case

add back in missing changes

add in vqe diagram

Apply suggestions from code review

Co-authored-by: Cassandra Granade <chgranad@microsoft.com>

Update README.md

process review comments

final run through

remove pip install cell
@guenp guenp requested a review from cgranade June 2, 2022 22:56
Copy link
Contributor

@cgranade cgranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I think the only thing left is to add these to binder-index.md as well.

@guenp
Copy link
Contributor Author

guenp commented Jun 6, 2022

@cgranade, the binder-index.md page says "Quantum Development Kit samples" and specifically mentions Q#, so I am not sure if this sample fits into the current index. I would add another section, for "Azure Quantum" samples. What are your thoughts?
Edit: I added it under the header "Azure Quantum Service" for now

@guenp guenp requested a review from xinyi-joffre June 6, 2022 22:34
@guenp
Copy link
Contributor Author

guenp commented Jun 14, 2022

This PR contains changes from #675 as well

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants