This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Open
Conversation
added 2 commits
June 2, 2022 15:54
add README Update README.md Update VQE-qiskit-hydrogen-ionq-sim.ipynb respond to code review comments update notebooks Update samples/azure-quantum/variational-quantum-eigensolver/VQE-qiskit-hydrogen-ionq-sim.ipynb Co-authored-by: Cassandra Granade <chgranad@microsoft.com> add in link to qiskit textbook add pip install, formatting and comments snake case add back in missing changes add in vqe diagram Apply suggestions from code review Co-authored-by: Cassandra Granade <chgranad@microsoft.com> Update README.md process review comments final run through remove pip install cell
cgranade
reviewed
Jun 2, 2022
Contributor
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
Looks good, thanks! I think the only thing left is to add these to binder-index.md as well.
Author
|
@cgranade, the binder-index.md page says "Quantum Development Kit samples" and specifically mentions Q#, so I am not sure if this sample fits into the current index. I would add another section, for "Azure Quantum" samples. What are your thoughts? |
Author
|
This PR contains changes from #675 as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add VQE notebooks with samples for IonQ and Quantinuum