Skip to content

[WIP] Avoid dependency on dynamic attribute lookup in drivers#7845

Draft
jenshnielsen wants to merge 27 commits intomicrosoft:mainfrom
jenshnielsen:better_instrument_types
Draft

[WIP] Avoid dependency on dynamic attribute lookup in drivers#7845
jenshnielsen wants to merge 27 commits intomicrosoft:mainfrom
jenshnielsen:better_instrument_types

Conversation

@jenshnielsen
Copy link
Collaborator

Not to merge directly. This pr disables delegate attributes getattr for type checking and updates drivers to not depend on dynamic attributes and fix any issues discovered as part of this. This pr will not be merged directly but cherry picked as it makes sense

@jenshnielsen jenshnielsen changed the title [WIP] [WIP] Avoid dependency on dynamic attribute lookup in drivers Feb 4, 2026
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 47.49035% with 136 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.86%. Comparing base (93f3df0) to head (d98bf90).
⚠️ Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
...odes/instrument_drivers/Keithley/_Keithley_2600.py 22.22% 42 Missing ⚠️
...rc/qcodes/instrument_drivers/Keysight/Infiniium.py 23.52% 13 Missing ⚠️
src/qcodes/instrument_drivers/rohde_schwarz/ZNB.py 7.69% 12 Missing ⚠️
src/qcodes/instrument_drivers/Keysight/N52xx.py 37.50% 10 Missing ⚠️
...strument_drivers/american_magnetics/AMI430_visa.py 57.14% 9 Missing ⚠️
...c/qcodes/instrument_drivers/rigol/Rigol_DS1074Z.py 11.11% 8 Missing ⚠️
...des/instrument_drivers/Keysight/Keysight_N9030B.py 53.33% 7 Missing ⚠️
...qcodes/instrument_drivers/rohde_schwarz/RTO1000.py 65.00% 7 Missing ⚠️
...rc/qcodes/instrument_drivers/QDev/QDac_channels.py 16.66% 5 Missing ⚠️
...c/qcodes/instrument_drivers/tektronix/AWG70000A.py 37.50% 5 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7845      +/-   ##
==========================================
- Coverage   59.88%   58.86%   -1.03%     
==========================================
  Files         352      352              
  Lines       31861    31915      +54     
==========================================
- Hits        19080    18786     -294     
- Misses      12781    13129     +348     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant