Add Tektronix DPO7200xx enhancements#7838
Add Tektronix DPO7200xx enhancements#7838bennthomsen wants to merge 2 commits intomicrosoft:mainfrom
Conversation
- Add TektronixDPOAcquisition module (mode, state, stop_after) - Add TektronixDPOCursor module (function, state, x1/x2/y1/y2 positions) - Add TektronixDPOMeasurementImmediate module - Enhance TektronixDPOTrigger (ready, state, level parameters) - Enhance TektronixDPOChannel (coupling parameter) - Add type annotations for submodules
|
@bennthomsen please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7838 +/- ##
==========================================
+ Coverage 59.88% 59.94% +0.06%
==========================================
Files 352 352
Lines 31865 31913 +48
==========================================
+ Hits 19082 19130 +48
Misses 12783 12783 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| unit="div", | ||
| ) | ||
| """Parameter position""" | ||
| """Parameter position [-8, 8] divisions""" |
There was a problem hiding this comment.
shoudl a validator Numbers(-8,8) be added as well to this parameter?
| ) | ||
| """Instrument module waveform""" | ||
|
|
||
| self.coupling: Parameter = self.add_parameter( |
There was a problem hiding this comment.
for typing and tab completion you can add this to indicate parameter's value types and instrument tpye it belongs to
| self.coupling: Parameter = self.add_parameter( | |
| self.coupling: Parameter[Literal["AC", "DC", "DCREJECT" "GND"], Self] = self.add_parameter( |
| "RUN", | ||
| "STOP", | ||
| ), | ||
| get_parser=str.lower, |
There was a problem hiding this comment.
why not upper to match what Enum validator is suggesting?
| get_parser=str.lower, | |
| get_parser=str.upper, |
|
@bennthomsen see also Ci failure - pre-commit hooks need to be run for formatting/linting |
Summary
Extends the Tektronix DPO7200xx oscilloscope driver with acquisition control, cursor measurements, and immediate
measurement capabilities.
New Modules
TektronixDPOAcquisition: Controls acquisition mode (sample,peakdetect,average,high_res,envelope), state (ON/OFF/RUN/STOP), and stop conditionsTektronixDPOCursor: Cursor positioning for voltage/time measurements with x1/x2 (seconds) and y1/y2 (volts)positions
TektronixDPOMeasurementImmediate: Immediate measurement functionality with configurable sources and gatingEnhancements
TektronixDPOTrigger: Addedready,state, andlevelparametersTektronixDPOChannel: Addedcouplingparameter (AC,DC,DCREJECT,GND)Checklist