-
Notifications
You must be signed in to change notification settings - Fork 343
Improve performance of is_function #7669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks @eendebakpt That seems very useful. In the long term I think we should consider completely removing and simplifying the command class from parameter but until then this seems like a nice improvement. I did not look into why the tests doesn't like this as is |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7669 +/- ##
==========================================
+ Coverage 58.93% 58.95% +0.01%
==========================================
Files 352 352
Lines 31806 31821 +15
==========================================
+ Hits 18744 18759 +15
Misses 13062 13062 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@microsoft-github-policy-service agree [company="TNO"] |
Tests are passing now. Simplifying the command class would indeed be great! One more performance improvement would be to skip the |
|
@microsoft-github-policy-service agree company=TNO |
|
@eendebakpt I don't think it's used much. Perhaps we could change the value for |
Yes, I had a similar idea. Added to the PR! |
For instruments with many parameters (100 - 1000 range) the overhead of qcodes parameters becomes a bottleneck in startup time. In this PR we improve performance of
is_function:Testing code:
(there are more bottlenecks, but
is_fuctionis used in creation of every Parameter and is quite heavy)