Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend doNd to support squashing not squashing output type #6422

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

jenshnielsen
Copy link
Collaborator

This is inspired by matplotlib plt.subplots

It makes it easier to write type checked code since with sqeeze=False you can always assume the output type to be the same. In the same was it also makes it easier to write dynamic code where you may or may not do more than one measurement

@jenshnielsen jenshnielsen requested a review from a team as a code owner September 6, 2024 08:02
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.29%. Comparing base (0b43223) to head (c38330d).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6422   +/-   ##
=======================================
  Coverage   67.29%   67.29%           
=======================================
  Files         352      352           
  Lines       32156    32160    +4     
=======================================
+ Hits        21638    21642    +4     
  Misses      10518    10518           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen added this pull request to the merge queue Sep 6, 2024
Merged via the queue into microsoft:main with commit db36f50 Sep 6, 2024
16 checks passed
@jenshnielsen jenshnielsen deleted the dond_squaz branch September 6, 2024 10:46
@jenshnielsen jenshnielsen mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants