Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] add basic read only mode to connect #4783

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jenshnielsen
Copy link
Collaborator

If we go this way there are a bunch of TODOs

  • Make sure this has good error messages
  • Expose to higher level api where it makes sense
  • Tests

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #4783 (653d700) into master (7da102b) will decrease coverage by 0.90%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #4783      +/-   ##
==========================================
- Coverage   68.20%   67.29%   -0.91%     
==========================================
  Files         339      339              
  Lines       32019    32046      +27     
==========================================
- Hits        21837    21565     -272     
- Misses      10182    10481     +299     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant