Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __init__.py files to data directories #4408

Merged
merged 6 commits into from
Jul 22, 2022

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Jul 21, 2022

Otherwise a deprecation warning is triggered when building the package.
See https://setuptools.pypa.io/en/latest/userguide/datafiles.html
for details. There seems to be a few ways to do this but adding
__init__.py files seems to be the easiest way.

Otherwise a deprecation warning is triggered when building the package.
See https://setuptools.pypa.io/en/latest/userguide/datafiles.html
for details. There seems to be a few ways to do this but adding
__init__ files seems to be the easiest way.
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #4408 (f1a762e) into master (8ceeb5c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4408   +/-   ##
=======================================
  Coverage   68.35%   68.35%           
=======================================
  Files         275      275           
  Lines       31021    31021           
=======================================
  Hits        21205    21205           
  Misses       9816     9816           

@astafan8 astafan8 merged commit d38994c into microsoft:master Jul 22, 2022
@jenshnielsen jenshnielsen deleted the build/add_data_init_files branch July 22, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants