Skip to content

FIX: count languages in the Multilingual run size estimate - #3084

Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 3 commits into
microsoft:mainfrom
u7k4rs6:fix/multilingual-estimate
Open

Utkarsh Bahuguna (u7k4rs6) wants to merge 3 commits into
microsoft:mainfrom
u7k4rs6:fix/multilingual-estimate

Conversation

@u7k4rs6

Copy link
Copy Markdown
Contributor

Fixes #3083.

Multilingual now has its own _estimate_run_size_async, shaped like the run it builds:

  • Baseline: one unit per seed group (when enabled)
  • Translation: seed groups x techniques x languages
  • Random translation: seed groups x techniques

The language count comes from a new _get_language_selection(), which holds the validation _resolve_languages_async already had (both selectors, empty list, num_languages range). The run path uses the same helper, so explicit languages get deduped the same way in both. Resume still replays the stored set.

Same repro on this branch:

default (5 random languages): estimate total=35 | initialized units=35
languages=[8 languages]:      estimate total=50 | initialized units=50

Test: estimate equals the initialized unit count for the default run, num_languages, duplicate languages, each strategy alone, baseline off and two techniques. 6 of the 7 fail on main (random-translation-only happens to match). tests/unit/scenario and backend: 3820 passed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Multilingual run size estimate ignores languages

2 participants