Repository navigation
FIX: count languages in the Multilingual run size estimate - #3084
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 3 commits into
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 3 commits into
Utkarsh Bahuguna (u7k4rs6) wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3083.
Multilingual now has its own
_estimate_run_size_async, shaped like the run it builds:The language count comes from a new
_get_language_selection(), which holds the validation_resolve_languages_asyncalready had (both selectors, empty list, num_languages range). The run path uses the same helper, so explicit languages get deduped the same way in both. Resume still replays the stored set.Same repro on this branch:
Test: estimate equals the initialized unit count for the default run, num_languages, duplicate languages, each strategy alone, baseline off and two techniques. 6 of the 7 fail on main (random-translation-only happens to match). tests/unit/scenario and backend: 3820 passed.