FIX: preserve child-result links when execution fails in SequentialAttack

[Akshat Shah (akshatshahh)]

Fixes #3039.

When a child of SequentialAttack raises, the child error result is persisted, but the orchestration parent's error result did not retain metadata["child_attack_result_ids"] — losing references to earlier children that completed before a later child failed, and to the failed child itself.

What changed

• pyrit/executor/attack/core/attack_strategy.py — the generic strategy error path (_on_error_async) now:
  • records the persisted error result's attack_result_id on the exception, so a catching orchestrator can link the failed child's stored result;
  • merges extra error-result metadata a failing strategy attached to the exception, and consumes it so an outer orchestrator doesn't re-merge stale links.
• pyrit/executor/core/strategy.py — when the execution wrapper re-raises as _StrategyRuntimeError, it propagates the persisted error-result id so orchestrators don't have to walk the cause chain.
• pyrit/executor/attack/compound/sequential_attack.py — _perform_async catches a child failure, attaches the ids of children that produced stored results (completed children in dispatch order, plus the failed child's persisted error result id), and re-raises unchanged.
• pyrit/exceptions/exception_context.py — the two exception-attribute constants, following the existing pattern of carrying failure context on the exception.

Per the issue's constraints: exception propagation is preserved (the child error still raises, verified by the tests), no thrown exception is turned into a returned error result, dispatch order is preserved, no ids are invented for children that never produced a stored result, and nested compounds link each level hierarchically.

Tests

New TestChildFailurePreservesLinks in tests/unit/executor/attack/compound/test_sequential_attack.py uses real strategies, the real AttackExecutor, and SQLite memory (no live targets):

• parent error result links the completed child and the failed child's persisted error result, in dispatch order;
• nested compounds link each envelope to its direct children;
• Scenario-attributed execution keeps both the links and the attribution.

Verified fail-first (new tests fail on unmodified base), then 55/55 in the compound test file, 275 passed across executor core/compound + exceptions suites, ruff check and format clean. The 2 failed / 13 errored tests in tests/unit/executor/attack/streaming and multi_turn are pre-existing on the base (missing optional deps), unrelated to this change.

AI disclosure

This contribution was developed with AI assistance (Muse). I reviewed and tested all changes; the fix was verified fail-first with real SQLite-backed execution as described above.

[Akshat Shah (akshatshahh)]

@microsoft-github-policy-service agree