Repository navigation
TEST: Stabilize conversation sends and isolate frontend mounts - #3015
Merged
Roman Lutz (romanlutz) merged 5 commits intoOct 8, 2026
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Adrian Gavrila (adrian-gavrila)
approved these changes
Oct 7, 2026
Richard Lundeen (richlundeen)
enabled auto-merge
October 8, 2026 04:44
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 8, 2026
Preserve both async wait helpers and guard failure-path test state. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Richard Lundeen (richlundeen)
added a commit
to richlundeen/PyRIT
that referenced
this pull request
Oct 8, 2026
Merge origin/main at c8aa5bd without conflicts, preserving scorer contracts, task cancellation cleanup, and matcher identity. Reuse only the backend test helpers and failing conversation-editor test repair from richlundeen's microsoft#3015 (789802b). Wait for a terminal send state and drain tasks before mock and database teardown; retain all existing assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ebae5d0f-7b81-4426-afaf-4e884f12cca3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix two backend test reliability issues in separate commits. Production code and dependencies are unchanged.
FINALIZING; it does not guarantee completion. Keep theCOMPLETED, target-binding, and owned-conversation assertions. Always shut down and drain owned sends before the send mock closes and SQLite teardown starts, including after assertion failures or timeouts.app.mountand checks the mount arguments. It no longer adds a catch-all static route to the shared app. That route caused the later resume GET test to return 404 instead of 405. The failure reproduced on unchanged upstream main and with only those two tests.The send failure occurred in the merge-queue job for #2979. These tests were unchanged by that PR. This PR starts from upstream main and is not stacked on #2979 or #3011. The changes do not overlap the changes in #3011.