Repository navigation
FEAT: add KnownBadSignatureScorer for EICAR / GTUBE / GTphish - #3009
Merged
Roman Lutz (romanlutz) merged 8 commits intoOct 10, 2026
Merged
Roman Lutz (romanlutz) merged 8 commits into
Roman Lutz (romanlutz) merged 8 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The scorer was shipped without a mention in doc/code/scoring; tests/unit/docs requires every registered scorer to appear there. Also applied ruff formatting to the new module. Signed-off-by: abdelhadi703 <abdelhadisalmaoui0909@outlook.fr>
Review feedback: a hit only proves the marker string is present. A scanner can detect a marker and still deliver the message, and a target may have no scanner in front of it at all, so the docstring and the notebook no longer claim the scorer establishes a missing or misconfigured scanner. Signed-off-by: abdelhadi703 <abdelhadisalmaoui0909@outlook.fr>
Contributor
Author
|
Both points addressed in 3b9656e. The docs entry is in On the |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Restore existing scorer documentation and match the paired Python notebook while preserving recorded outputs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Roman Lutz (romanlutz)
approved these changes
Oct 9, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 9, 2026
Wait for actual SDK dispatch before applying the test watchdog. Cover slow startup explicitly and preserve timeout wrapping, no-replay and cleanup assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a known-bad signature scorer (EICAR / GTUBE / GTphish)
PyRIT had no scorer for the standard scanner test signatures, so there was no way to
check whether a target returns a string an antivirus (EICAR), anti-spam (GTUBE) or
anti-phishing (GTphish) scanner should have stopped. Garak covers this with
av_spam_scanning; this adds the PyRIT-side detection.What I changed:
KnownBadSignatureScorerinpyrit/score/true_false/regex/, built on theexisting
RegexScorerwith the three signatures as default patternspyrit.scoreandpyrit.score.true_false.regextests/unit/score/regex/test_known_bad_signature_scorer.pyOne detail worth flagging: the signatures are the real EICAR/GTUBE/GTphish strings, and
a contiguous literal in a source file trips real-time AV on developer machines and CI
checkouts (the file gets quarantined before it's read). I assemble them from fragments
so the on-disk file stays inert while the runtime value is byte-for-byte the real
signature.
Testing:
pytest tests/unit/score/regex/test_known_bad_signature_scorer.py— 10 passed.Refs #511