FIX: keep user-authored working text across runtime generation changes

[Manohar Paturi (ManoharPaturi)]

Refs #2867

what happens

useChatConverters cleared workingInputs when the runtime generation changed, so a successful live reinitialization replaced manually edited working-copy text with the original composer text. An administrator applying config in another tab could discard another user's unsent work (P1, per issue).

fix

the generation-change branch keeps workingInputs and only invalidates the generated results (stageResults, errors, applied). working entries for pieces that no longer exist are inert since lookups are by current input id.

tests

two regression tests in a new hook test file: working text survives a generation swap, and generated stage results still clear. both fail on main (the first asserts the surviving edit; on main it comes back undefined), pass here.

env: main c32546a

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Manohar Paturi (ManoharPaturi)]

Roman Lutz (@romanlutz) both points addressed:

• the 🔴: the generation branch now runs the same piece reconciliation reconcileInputs applies, so a working edit survives only when its underlying value is unchanged. your exact scenario — composer changes from first draft to second draft while the generation advances — drops the stale edit instead of displaying it against the new text. new test pins it.
• the 🟡: tests now reset the mocked generation before each test, and the clear-test creates a real stage result through a mocked previewConversion run before asserting it clears on the swap.

all three green locally, tsc clean.

[Manohar Paturi (ManoharPaturi)]

Roman Lutz (@romanlutz) both added:

• the pipeline test now calls apply() after the conversion run and asserts applied['text'] exists, then verifies it is gone after the generation swap.
• new test for the configured-pipeline working-copy path from the second reproduction: pipeline configured, hand edit on the working copy (no run), generation change — the edit survives while the generated result clears.

4/4 green.

[Manohar Paturi (ManoharPaturi)]

Roman Lutz (@romanlutz) good catch again — the old version asserted a result that never existed. the configured-pipeline test now runs convert() after the hand edit, asserts stageResults['text'] has the real generated stage, then advances the generation and checks both halves: the working edit survives AND the generated result clears. 4/4 green.

[Roman Lutz (romanlutz)]

I also left one comment thread open. Please take a look at that one.

[Manohar Paturi (ManoharPaturi)]

Roman Lutz (@romanlutz) done — the configured-pipeline test now runs convert() after the hand edit (asserting a real stage result exists), then advances the generation and checks both halves: the hand edit survives while the generated result clears. pushed in 714f455, 4/4 green.