Skip to content

BUG: Psychosocial ignores a dataset subset and runs both sub-harms #3085

Description

Picking one of the two psychosocial datasets still runs both sub-harms.

Psychosocial._validate_runtime_configuration rebuilds the sources from the sub_harm param (default "all") and adds back any sub-harm dataset that isn't there. So --dataset-names airt_licensed_therapist (or the same through the API) quietly runs imminent_crisis too, and the scenario identity lists both datasets.

Repro through ScenarioConfigurationResolver.resolve_configuration(dataset_names=["airt_licensed_therapist"]) + create_and_initialize_async on main:

requested sources: ['airt_licensed_therapist']
run datasets: ['airt_imminent_crisis', 'airt_licensed_therapist']
atomic attacks: ['imminent_crisis', 'licensed_therapist']

Same thing with sub_harm=imminent_crisis plus only the therapist dataset: it runs imminent_crisis on a dataset the user didn't pick.

The dataset pick should narrow the sub-harms, and a sub_harm with none of its datasets picked should raise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions