-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[PT Run] Split indexer plugin's queries into a fast and slow query #5748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arjunbalgovind
merged 20 commits into
microsoft:master
from
arjunbalgovind:user/arbalgov/indexerQueryHelper
Aug 11, 2020
Merged
[PT Run] Split indexer plugin's queries into a fast and slow query #5748
arjunbalgovind
merged 20 commits into
microsoft:master
from
arjunbalgovind:user/arbalgov/indexerQueryHelper
Aug 11, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/modules/launcher/Plugins/Microsoft.Plugin.Indexer/SearchHelper/WindowsSearchAPI.cs
Outdated
Show resolved
Hide resolved
dsrivastavv
reviewed
Aug 11, 2020
…delayed exec plugins when bool param is true
dsrivastavv
approved these changes
Aug 11, 2020
Contributor
dsrivastavv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
This PR adds in a new interface to for plugins which take longer to execute. If the flag in metadata is set to true, two versions of the plugin get executed, first a fast version along with the other plugins and then a slower version after all the other plugins had finished.
PR Checklist
Info on Pull Request
What does this include?
_lockin WindowsSearchAPI since there could be multiple instances of indexer query occurring. To avoid the error from OleDB throwing exceptions in ExecuteReader (https://github.com/microsoft/Launcher/pull/70) we add checks for whether the reader is closed. While testing, the exceptions were generally occurring only on the older queries which would get cancelled eventually. Otherwise this would cause the slower query from a previous execution to block the list view from updating when the next query is made since it will wait even for the fast indexer plugin.Validation Steps Performed
How does someone test & validate?