Refactoring KeyVisual#40904
Merged
niels9001 merged 2 commits intoniels9001/new-dashboard-uxfrom Jul 31, 2025
Merged
Conversation
Jaylyn-Barbee
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had 2 issues with the refactoring of KeyVisual that happened in #40214:
With this PR
RenderKeyAsGlyphhas been introduced to render a key as an icon (to save space in certain scenarios) or to show the full text (default)AI Summary
This pull request refactors the implementation of the
KeyVisualcontrol in the Settings UI by introducing a newKeyCharPresentercontrol and reorganizing related XAML resources. The changes improve modularity and maintainability, and update the visual structure and styling of key representations.Key changes include:
Refactoring and Code Organization:
KeyVisual(KeyVisual.xaml.cs) has been removed, and its logic is now handled through XAML templating and the newKeyCharPresentercontrol.KeyVisual.xamlfile has been moved to theKeyVisualsubfolder and updated to reference the newKeyCharPresenterfor displaying key content. [1] [2]Introduction of KeyCharPresenter:
KeyCharPresentercontrol (KeyCharPresenter.xamlandKeyCharPresenter.xaml.cs) for rendering key characters and glyphs with dedicated styles for default, Windows key, and glyph keys. [1] [2]UI and Style Updates:
KeyVisualcontrol template to use aGridcontainingKeyCharPresenter, improving layout flexibility and separation of concerns.KeyVisual, such as padding, font size, and accessibility properties.App.xaml, as the new approach handles this via styles.Overall, these changes modernize the way key visuals are rendered and styled, making the codebase cleaner and easier to extend in the future.