Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows 10 title bar borders #36429

Merged
merged 11 commits into from
Jan 13, 2025
Merged

Fix Windows 10 title bar borders #36429

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ecf0f78
Fix borders for windows in the Settings UI
pingzing Dec 18, 2024
9b1161b
Fix HOSTS window
pingzing Dec 18, 2024
b2fe2b1
Fix Advanced Paste
pingzing Dec 18, 2024
2cd50e5
Fix Environment Variables
pingzing Dec 18, 2024
0da6d7f
Fix File Locksmith
pingzing Dec 18, 2024
623b84e
Fix Peek, with a caveat
pingzing Dec 18, 2024
01caed5
Fix Registry Preview
pingzing Dec 18, 2024
f5dbc57
Remove unused imports
pingzing Dec 18, 2024
1b5906c
Clean up imports in OobeShellPage
pingzing Dec 18, 2024
18d0b8b
Move OSVersionHelper from Common.UI up into ManagedCommon
pingzing Jan 8, 2025
74c9408
Merge branch 'main' into pr36429
jaimecbernardo Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Registry Preview
  • Loading branch information
@pingzing
pingzing committed Dec 18, 2024
commit 01caed5df01c7d45acdb2d86ab6339db9c0c1076
5 changes: 3 additions & 2 deletions src/modules/registrypreview/RegistryPreview/RegistryPreviewXAML/MainWindow.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ internal MainWindow()
OpenWindowPlacementFile(settingsFolder, windowPlacementFile);

// Update the Win32 looking window with the correct icon (and grab the appWindow handle for later)
IntPtr windowHandle = WinRT.Interop.WindowNative.GetWindowHandle(this);
Microsoft.UI.WindowId windowId = Win32Interop.GetWindowIdFromWindow(windowHandle);
IntPtr windowHandle = this.GetWindowHandle();
WindowId windowId = Win32Interop.GetWindowIdFromWindow(windowHandle);
appWindow = Microsoft.UI.Windowing.AppWindow.GetFromWindowId(windowId);
appWindow.SetIcon("Assets\\RegistryPreview\\RegistryPreview.ico");

Expand All @@ -49,6 +49,7 @@ internal MainWindow()

// Extend the canvas to include the title bar so the app can support theming
ExtendsContentIntoTitleBar = true;
WindowHelpers.ForceTopBorder1PixelInset(windowHandle);
SetTitleBar(titleBar);

// if have settings, update the location of the window
Expand Down