Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspaces] add check on project id when launching from editor #34802

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

donlaci
Copy link
Collaborator

@donlaci donlaci commented Sep 11, 2024

Summary of the Pull Request

check project id when launching from editor. In edge case the temporal json file might contain a different workspace
For better explanaition: the temporal json file exists during the user edits a workspace. In normal cases, when he or she saves or cancels the edit process, the file gets deleted. But there might be unexpected cases like the workspaces process gets killed from the Task Manager or there is a power supply failure because of a tsunami, earthquake or heavy rain.
The in the first round implemented logic that the project, which the user wants to launch can be found either in the "normal" workspaces.json (there we check the ID) tipically when launching a saved workspace or in the temporal workspaces.json tipically when launching the currently edited workspace, in the above mentioned edge cases leads to launch of a non-expected workspace. To avoid that, the project search process has to be extended with the check of the project id also for the temporal json file.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, Laszlo!

This comment has been minimized.

@donlaci
Copy link
Collaborator Author

donlaci commented Sep 19, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SeraphimaZykova SeraphimaZykova merged commit cf470a6 into microsoft:main Sep 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants