Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log extension #33813

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Change log extension #33813

wants to merge 3 commits into from

Conversation

benwa
Copy link

@benwa benwa commented Jul 13, 2024

From .txt to .log

Summary of the Pull Request

Changes the log file extension to .log for enhanced tool usage.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Changed all log file extensions from .txt to .log. This honors system and user defined file associations like CMTrace. It also automatically enables syntax highlighting in software like VSCode.

Validation Steps Performed

Manually verified log files and bundled support zip.

From .txt to .log
@benwa
Copy link
Author

benwa commented Jul 13, 2024

@microsoft-github-policy-service agree

@Jay-o-Way
Copy link
Collaborator

Is this backwards compatible or a breaking change?

@benwa
Copy link
Author

benwa commented Jul 14, 2024 via email

@benwa
Copy link
Author

benwa commented Sep 1, 2024

Is there any interest in this PR?

@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Sep 6, 2024
@crutkas
Copy link
Member

crutkas commented Sep 6, 2024

Sorry, right now the team was heads down on workspaces and getting stuff prepped for winappsdk upgrade.

Added need review tag for this.

/azp run as it looks like it has test failures, lets see if this was random since i don't think this should have caused that failure

@jaimecbernardo
Copy link
Collaborator

Merged in latest main. Note to self: when testing, verify that the tools/ executables take this into account, some of them seem to require using log and we have to verify when testing that they're still picking up the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants